@keewis I enabled Build pull requests for this project I guess that is all, right?

indeed. You should have gotten a message from github requesting the access. If so, we should be able to close/reopen this to see the effect. Let's try:

I don't see it in the status. I am checking if the webhook is ok

for reference, here's the docs on that feature: https://docs.readthedocs.io/en/stable/pull-requests.html

Somehow there has not been

it's there now! Thanks!

Just for the record, the read the docs documentation instructs to enable the webhook for Branch or tag creation, Branch or tag deletion and Pushes events It seems that you also need to enable for Pull requests when this feature is used.

@keewis We also need to check that the visibility of the generated docs are fine. ping me to let me know if something is not ok.

We also need to check that the visibility of the generated docs are fine.

Not sure if I understand this correctly. Could you elaborate?

Edit: the build currently fails because of an issue with numpy and sparse (it's the same for master)

Ohh, when I was going to link to a reference I found (Privacy levels are only supported on Read the Docs for Business.) So do not worry, I was afraid that the outcome of the preview was only visible to me!

This preview feature is great! How about dividing the index? It seems too crowded. This is a proposal

Getting started
    Installation
    Tutorial

User Guide
    Defining Quantities
    String formatting
    Temperature conversion
    Logarithmic Units

Rolling your own conversions and making a better use of those included (find a short title)
    Defining units
    Different Unit Systems (and default units)
    Contexts

Interaction with other packages
    NumPy Support
    Serialization
    Plotting with Matplotlib
    Pandas support

Other cool stuff (find a title)
    Buckingham Pi Theorem
    Optimizing Performance
    Wrapping and checking functions
    Using Pint for currency conversions
    Using Measurements (I want to extract measurements to another package, and then this will go to Interaction with other packages)

More information
    Command-line script
    Developer reference
    Contributing to Pint
    Frequently asked questions

indeed. I think @jules-ch wanted to do a reorganization of the docs and introduce a new theme (see #972), which is where I would do this, too.

now that the last issue is resolved this should be ready for a final review

Hi @keewis , I just read the proposed formatter docs: I found them great!
Just one minor thing: I found that the difference between the C format type specifier for the units and the # modifier for quantities is not easy to grasp on a quick reading (on my first glance I actually assumed that there was a typo and that you meant C where you wrote #). Perhaps a note or some clarification in the text could help?

Maybe something like adding "(see also the related # modifier)" when first mentioning C?

they actually do different things, despite their naming: # will convert to a unit that makes the quantity have as few decimal digits as possible while C will reduce the space taken up by operators (e.g. by not padding them with spaces).

I guess we should try to make the naming more distinct (maybe rename C to N for narrow or T for tiny?), and I can also add a more detailed explanation to both, maybe by replacing the format type's name with a "description" column?

Edit: in any case, thanks for the review

@keewis you are right! I was still confused even after a not-so-quick read (but the blame is on me, not on the text! )

well, texts can be written in a way that is less misleading, even if the reader is less attentive. I will try to see if I can make the difference a bit more visible.

@keewis I'm gonna merge this.
It's a good addition to the docs.
If you want to amend this, open a PR I'll be happy to merge it.